artem/yt-dlp
1
0
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2026-07-01 07:49:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ie/youtube] Fix outdated quickjs-ng warning (#16437)

Browse Source 
Ref: https://github.com/quickjs-ng/quickjs/pull/1324

Closes #16403
Authored by: bashonly
This commit is contained in:
bashonly 2026-04-05 12:03:47 -05:00 committed by GitHub
parent f14d2f2d54
commit 04b2261cbf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
yt_dlp/extractor/youtube/jsc/_builtin/quickjs.py
View File

@ -21,12 +21,20 @@ from yt_dlp.utils import Popen
class QuickJSJCP(EJSBaseJCP, BuiltinIEContentProvider): class QuickJSJCP(EJSBaseJCP, BuiltinIEContentProvider):
PROVIDER_NAME = 'quickjs' PROVIDER_NAME = 'quickjs'
JS_RUNTIME_NAME = 'quickjs' JS_RUNTIME_NAME = 'quickjs'
_QJS_MIN_RECOMMENDED = {
'quickjs': (2025, 4, 26),
'quickjs-ng': (0, 12, 0),
}
_QJS_WARNING_TMPL = (
'{name} versions older than {version} are missing important optimizations '
'and will solve the JS challenges very slowly. Consider upgrading.')
def _run_js_runtime(self, stdin: str, /) -> str: def _run_js_runtime(self, stdin: str, /) -> str:
if self.runtime_info.name == 'quickjs-ng': min_recommended_version = self._QJS_MIN_RECOMMENDED[self.runtime_info.name]
self.logger.warning('QuickJS-NG is missing some optimizations making this very slow. Consider using upstream QuickJS instead.') if self.runtime_info.version_tuple < min_recommended_version:
elif self.runtime_info.version_tuple < (2025, 4, 26): self.logger.warning(self._QJS_WARNING_TMPL.format(
self.logger.warning('Older QuickJS versions are missing optimizations making this very slow. Consider upgrading.') name=self.runtime_info.name,
version='.'.join(map(str, min_recommended_version))))
# QuickJS does not support reading from stdin, so we have to use a temp file # QuickJS does not support reading from stdin, so we have to use a temp file
temp_file = tempfile.NamedTemporaryFile(mode='w', suffix='.js', delete=False, encoding='utf-8') temp_file = tempfile.NamedTemporaryFile(mode='w', suffix='.js', delete=False, encoding='utf-8')