From 3128f6a43399cec279aa3db37cb9c9c2ad95c539 Mon Sep 17 00:00:00 2001 From: doe1080 <98906116+doe1080@users.noreply.github.com> Date: Sun, 16 Aug 2026 04:52:26 +0900 Subject: [PATCH] [test:networking] Fix logging handler removal test (#17379) Ref: https://github.com/python/cpython/issues/79366 Authored by: doe1080 --- test/test_networking.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/test_networking.py b/test/test_networking.py index 067108905d..ee648938cf 100644 --- a/test/test_networking.py +++ b/test/test_networking.py @@ -859,15 +859,15 @@ class TestRequestHandlerMisc: ('Websockets', 'websockets.server'), ], indirect=['handler']) def test_remove_logging_handler(self, handler, logger_name): - # Ensure any logging handlers, which may contain a YoutubeDL instance, - # are removed when we close the request handler + # Ensure closing the request handler removes only its logging handlers, + # which may reference a YoutubeDL instance # See: https://github.com/yt-dlp/yt-dlp/issues/8922 - logging_handlers = logging.getLogger(logger_name).handlers - before_count = len(logging_handlers) + logger = logging.getLogger(logger_name) + original_handlers = logger.handlers.copy() rh = handler() - assert len(logging_handlers) == before_count + 1 + assert len(logger.handlers) == len(original_handlers) + 1 rh.close() - assert len(logging_handlers) == before_count + assert logger.handlers == original_handlers def test_wrap_request_errors(self): class TestRequestHandler(RequestHandler):