From 68bc679666039faa4fab53a06de5391bcadf6433 Mon Sep 17 00:00:00 2001 From: coletdjnz Date: Sun, 18 May 2025 12:14:24 +1200 Subject: [PATCH] more suggestions from review --- yt_dlp/extractor/youtube/pot/_builtin/memory_cache.py | 2 +- yt_dlp/extractor/youtube/pot/_director.py | 3 +-- yt_dlp/extractor/youtube/pot/provider.py | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/yt_dlp/extractor/youtube/pot/_builtin/memory_cache.py b/yt_dlp/extractor/youtube/pot/_builtin/memory_cache.py index 31fa06ae8f..0062876eb2 100644 --- a/yt_dlp/extractor/youtube/pot/_builtin/memory_cache.py +++ b/yt_dlp/extractor/youtube/pot/_builtin/memory_cache.py @@ -38,7 +38,7 @@ class MemoryLRUPCP(PoTokenCacheProvider, BuiltinIEContentProvider): def __init__( self, *args, - initialize_cache: typing.Callable[[int], tuple[OrderedDict, Lock, int]] = initialize_global_cache, + initialize_cache: typing.Callable[[int], tuple[OrderedDict[str, tuple[str, int]], Lock, int]] = initialize_global_cache, **kwargs, ): super().__init__(*args, **kwargs) diff --git a/yt_dlp/extractor/youtube/pot/_director.py b/yt_dlp/extractor/youtube/pot/_director.py index a35917afe1..aaf1d5290a 100644 --- a/yt_dlp/extractor/youtube/pot/_director.py +++ b/yt_dlp/extractor/youtube/pot/_director.py @@ -139,8 +139,7 @@ class PoTokenCache: } if spec._provider: bindings_cleaned['_p'] = spec._provider.PROVIDER_KEY - self.logger.trace( - 'Generate cache key bindings: {}'.format(', '.join(f'{k}={v}' for k, v in bindings_cleaned.items()))) + self.logger.trace(f'Generated cache key bindings: {bindings_cleaned}') return bindings_cleaned def _generate_key(self, bindings: dict) -> str: diff --git a/yt_dlp/extractor/youtube/pot/provider.py b/yt_dlp/extractor/youtube/pot/provider.py index 1a28070561..53af92d30b 100644 --- a/yt_dlp/extractor/youtube/pot/provider.py +++ b/yt_dlp/extractor/youtube/pot/provider.py @@ -244,7 +244,7 @@ def provider_bug_report_message(provider: IEContentProvider, before=';'): if not before or before.endswith(('.', '!', '?')): msg = msg[0].title() + msg[1:] - return (before + ' ' if before else '') + msg + return f'{before} {msg}' if before else msg def register_preference(*providers: type[PoTokenProvider]) -> typing.Callable[[Preference], Preference]: