Alexandre Ramos
8ec164054e
Fix #9970 : FFmpeg requires ext in filename for FFmpegMetadataPP
...
Output templates resulting in filenames with only dots preceding the
extension would be passed to ffmpeg for embeding metadata with .temp
in the extension field because os.path.splitext would not find and
extension field in those filenames.
As a result ffmpeg would fail to determine what the output extension
should be and fail.
To solve this a must_have_ext argument was added to _change_extension
so that where a extension is required the expected extension will be
used in those cases where os.path.splitext returns an empty string for
the extension field.
existing_video_file in YoutubeDL.py was also changed so it won't
overwrite info_dict['ext'] with an empty string if os.path.splitext
returns an empty string for the extension field. This fixes #9970 .
2025-03-22 18:26:18 +00:00
f36e4b6e65
[cleanup] Misc ( #12526 )
...
Authored by: Grub4K, seproDev, gamer191, dirkf
Co-authored-by: sepro <sepro@sepr0.com >
2025-03-21 23:41:56 +00:00
Kenshin9977 and GitHub
9f77e04c76
Fix external downloader availability when using --ffmpeg-location ( #12318 )
...
This fix is only applicable to the CLI option
Authored by: Kenshin9977
2025-02-23 08:50:43 +00:00
sepro and GitHub
d8fb349086
[cleanup] Bump ruff to 0.8.x ( #11608 )
...
Authored by: seproDev
2024-12-02 16:29:30 +01:00
sepro and GitHub
f95a92b3d0
[cleanup] Deprecate more compat functions ( #11439 )
...
Authored by: seproDev
2024-11-17 00:24:11 +01:00
6aaf96a3d6
[cleanup] Misc ( #10075 )
...
Closes #10303
Authored by: bashonly, seproDev, jucor, c-basalt
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com >
Co-authored-by: Julien Cornebise <julien@cornebise.com >
Co-authored-by: c-basalt <117849907+c-basalt@users.noreply.github.com >
2024-07-01 22:51:27 +00:00
sepro and GitHub
add96eb9f8
[cleanup] Add more ruff rules ( #10149 )
...
Authored by: seproDev
Reviewed-by: bashonly <88596187+bashonly@users.noreply.github.com >
Reviewed-by: Simon Sawicki <contact@grub4k.xyz >
2024-06-12 01:09:58 +02:00
Lev and GitHub
104a7b5a46
[ie] Migrate commonly plural fields to lists ( #8917 )
...
Authored by: llistochek, pukkandan
Related: #3944
2024-02-20 12:49:24 +05:30
bashonly and GitHub
deeb13eae8
[pp/FFmpegMetadata] Embed stream metadata in single format downloads ( #8647 )
...
Closes #8568
Authored by: bashonly
2023-11-26 02:40:09 +00:00
bashonly and GitHub
3f7e2bd80e
[FFmpegFixupM3u8PP] Check audio codec before fixup ( #6778 )
...
Closes #6673
Authored by: bashonly
2023-04-13 19:21:09 +00:00
Lesmiscore and GitHub
0f0875ed55
[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix error on attaching thumbnails and info json for mkv/mka ( #6647 )
...
Authored by: Lesmiscore
Current yt-dlp code never hit this bug, but would hit once filename sanitization gets better
2023-03-28 01:17:42 +09:00
bashonly and GitHub
01ddec7e66
[postprocessor] Fix chapters if duration is not extracted ( #6037 )
...
Authored by: bashonly
2023-03-08 13:10:19 +00:00
Chris Caruso and GitHub
f737fb16d8
[ExtractAudio] Handle outtmpl without ext ( #6005 )
...
Authored by: carusocr
Closes #5968
2023-02-17 13:36:15 +05:30
pukkandan
d80ca5deaa
[utils] mimetype2ext: weba is not standard
...
Fix bug in fbb7383306 , 2647c933b8
Closes #5935
2023-01-03 11:25:01 +05:30
pukkandan
08e29b9f1f
[cleanup] Misc
...
Closes #5576 , closes #5887
2023-01-02 19:40:15 +05:30
pukkandan
69f5fe45b9
[FFmpegVideoConvertor] Add gif to --recode-video
2022-12-23 01:44:20 +05:30
Robert Geislinger and pukkandan
7aaf4cd2a8
[cleanup] Misc
...
Closes #5471 , Closes #5312
Authored by: pukkandan, Alienmaster
2022-11-11 15:48:29 +05:30
pukkandan
8522226d2f
[ThumbnailsConvertor] Fix filename escaping
...
Closes #4604
Authored by: pukkandan, dirkf
2022-11-11 15:28:19 +05:30
pukkandan
da4db748fa
[utils] Add deprecation_warning
...
See https://github.com/yt-dlp/yt-dlp/pull/2173#issuecomment-1097021515
2022-08-30 21:03:07 +05:30
pukkandan
0e0ce898f6
[ThumbnailsConvertor] Fix conversion after fixup_webp
...
Closes #4565
2022-08-14 20:34:55 +05:30
pukkandan
8420a4d063
[ffmpeg] Smarter detection of ffprobe filename
2022-08-11 07:23:45 +05:30
pukkandan
c220d9efc8
[ffmpeg] Disable avconv unless --prefer-avconv
2022-08-09 05:15:38 +05:30
pukkandan
5f2a7f7c4a
[FFmpegThumbnailsConvertor] Fix conversion from GIF
...
Closes #2988
2022-08-01 07:36:08 +05:30
pukkandan
4f04be6add
Validate --merge-output-format
...
Closes #4489
2022-07-31 02:20:14 +05:30
pukkandan
8dc5930511
[utils, cleanup] Consolidate known media extensions
2022-07-31 02:20:13 +05:30
pukkandan
6a7d3a0a09
[ffmpeg] Set ffmpeg_location in a contextvar
...
Fixes #2191 for the CLI, but not when used through the API
2022-07-31 02:20:12 +05:30
pukkandan
3bec830a59
Reject entire playlists faster with --match-filter
...
Rejected based on `playlist_id` etc can be checked before any entries are extracted
Related: #4383
2022-07-26 09:33:12 +05:30
pukkandan
f2df407165
[cleanup] Misc cleanup
2022-07-09 09:07:10 +05:30
crazymoose77756 and GitHub
962ffcf89c
[cleanup] Fix some typos ( #4194 )
...
Authored by: crazymoose77756
2022-06-26 17:50:06 -07:00
pukkandan
f67baae17e
[ffmpeg] Write full output to debug on error
...
Bug in f0c9fb9682
2022-06-23 09:17:34 +05:30
christoph-heinrich and GitHub
e121e3cee7
[cleanup] Minor fixes ( #4096 )
...
Authored by: christoph-heinrich
2022-06-17 18:57:22 -07:00
pukkandan
f0c9fb9682
[utils] Popen: Refactor to use contextmanager
...
Fixes https://github.com/yt-dlp/yt-dlp/issues/3531#issuecomment-1156223597
2022-06-16 06:23:50 +05:30
pukkandan
e0ab98541c
[ExtractAudio] Allow conditional conversion
...
Closes #1715
2022-06-06 21:51:28 +05:30
pukkandan
35faefee5d
[ExtractAudio, cleanup] Refactor
2022-06-06 21:49:57 +05:30
pukkandan
00bbc5f177
[ThumbnailsConvertor] Allow conditional conversion
...
Closes #3970
2022-06-05 20:51:19 +05:30
pukkandan
1890fc6389
[cleanup] Misc fixes
...
Cherry-picks from: #3498 , #3947
Related: #3949 , https://github.com/yt-dlp/yt-dlp/issues/1839#issuecomment-1140313836
Authored by: pukkandan, flashdagger, gamer191
2022-06-03 21:45:35 +05:30
pukkandan
8a82af3511
[cleanup] Misc fixes and cleanup
...
Closes #3780 , Closes #3853 , Closes #3850
2022-05-27 04:43:43 +05:30
pukkandan
d9473db78a
[ModifyChapters] Fix repeated removal of small segments
...
Closes #3846
2022-05-23 16:12:33 +05:30
pukkandan
3a85e9cee9
[ffmpeg] Check version lazily
...
Closes #3830
2022-05-22 19:56:22 +05:30
pukkandan
5792c950bf
[compat] Implement compat.imghdr
...
Python 3.11 deprecates `imghdr` module
2022-05-17 19:46:01 +05:30
pukkandan
43d7f5a5d0
[EmbedThumbnail] Do not obey -k
2022-05-01 04:58:26 +05:30
pukkandan
e13945a2fe
[ffmpeg] Fix features detection
2022-04-27 05:36:06 +05:30
pukkandan
ca04e1bf49
[Metadata] Remove filename from attached info-json
2022-04-27 01:19:06 +05:30
pukkandan
1e9969f4f5
bugfix for a44ca5a470, 19a0394044, 77f9033095
...
Closes #3472
2022-04-19 02:59:20 +05:30
pukkandan
743f39750c
Fix bug in 66cf3e1001
2022-04-12 19:57:08 +05:30
pukkandan
66cf3e1001
[EmbedSubtitle] Enable for more video extensions
...
Closes #3382
2022-04-12 05:32:53 +05:30
pukkandan
f82711587c
[cleanup] Sort imports
...
Using https://github.com/PyCQA/isort
isort -m VERTICAL_HANGING_INDENT --py 36 -l 80 --rr -n --tc .
2022-04-12 05:32:52 +05:30
pukkandan
86e5f3ed2e
[cleanup] Upgrade syntax
...
Using https://github.com/asottile/pyupgrade
1. `__future__` imports and `coding: utf-8` were removed
2. Files were rewritten with `pyupgrade --py36-plus --keep-percent-format`
3. f-strings were cherry-picked from `pyupgrade --py36-plus`
Extractors are left untouched (except removing header) to avoid unnecessary merge conflicts
2022-04-12 05:32:51 +05:30
pukkandan
5a727063c5
[FFmpegMetadataPP] Remove \0 from metadata
2022-04-12 01:15:19 +05:30
pukkandan
22fba53fbd
[FfmpegMetadata] Write id3v1 tags
2022-04-07 15:51:23 +05:30