mirror/nanobot
1
0
Fork 0
mirror of https://github.com/HKUDS/nanobot.git synced 2026-08-04 08:28:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(triggers): treat null runHistory as empty when loading triggers

Browse Source
This commit is contained in:
santhreal 2026-07-25 21:47:05 -07:00 committed by Xubin Ren
parent aaf2eef568
commit 07c3e02d5c
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nanobot/triggers/local_types.py
View File

@ -68,9 +68,10 @@ class LocalTrigger:
@classmethod
def from_dict(cls, data: dict[str, Any]) -> "LocalTrigger":
raw_history = data.get("runHistory", data.get("run_history", [])) or []
history = [
record if isinstance(record, TriggerRunRecord) else TriggerRunRecord.from_dict(record)
for record in data.get("runHistory", data.get("run_history", []))
for record in raw_history
if isinstance(record, (dict, TriggerRunRecord))
]
return cls(

18
tests/triggers/test_local_triggers.py
View File

@ -617,3 +617,21 @@ def test_local_trigger_from_dict_coerces_string_last_run_at_ms() -> None:
}
)
assert trigger_null.last_run_at_ms is None
def test_local_trigger_from_dict_accepts_null_run_history() -> None:
"""Null runHistory must load as empty, matching CronJobState.from_store_dict."""
trigger = LocalTrigger.from_dict(
{
"id": "t1",
"name": "n",
"enabled": True,
"channel": "websocket",
"chatId": "c1",
"sessionKey": "websocket:c1",
"runHistory": None,
"createdAtMs": 1,
"updatedAtMs": 1,
}
)
assert trigger.run_history == []