fix(tui): preserve keyboard picker selection

This commit is contained in:
chengyongru
2026-08-21 18:23:04 +08:00
committed by chengyongru
parent 252ea18e88
commit 4561c748f6
2 changed files with 32 additions and 1 deletions
+4 -1
View File
@@ -137,7 +137,10 @@ export class PickerMenu<T> {
? { backgroundColor: RGBA.fromHex(this.theme.selectedBackground) }
: {}),
attributes: selected ? TextAttributes.BOLD : 0,
onMouseOver: () => {
// OpenTUI rechecks hover after rows are rebuilt. Treating that synthetic
// `over` as pointer intent would undo a keyboard move whenever the mouse
// remains over the previously selected row.
onMouseMove: () => {
if (this.selected === index) return
this.selected = index
this.render()
+28
View File
@@ -63,6 +63,34 @@ describe("SessionMenu", () => {
)
})
test("keeps keyboard selection when the pointer stays over the previous row", async () => {
setup = await createTestRenderer({ width: 80, height: 18, screenMode: "alternate-screen" })
const menu = new SessionMenu(setup.renderer, {
text: "#FFFFFF",
muted: "#999999",
border: "#555555",
})
setup.renderer.root.add(menu.root)
menu.open(sessions, "one", 6)
await setup.renderOnce()
const firstRow = menu.root.getChildren()[0]
const secondRow = menu.root.getChildren()[1]
if (!firstRow || !secondRow) throw new Error("session rows were not rendered")
const firstPosition = { x: firstRow.x + 2, y: firstRow.y }
await setup.mockMouse.moveTo(secondRow.x + 2, secondRow.y)
await setup.flush()
expect(menu.choose()?.chatId).toBe("two")
await setup.mockMouse.moveTo(firstPosition.x, firstPosition.y)
await setup.flush()
expect(menu.choose()?.chatId).toBe("one")
expect(menu.move(1)).toBe(true)
await setup.flush()
expect(menu.choose()?.chatId).toBe("two")
})
test("shows compact workspace names only when they distinguish sessions", async () => {
setup = await createTestRenderer({ width: 100, height: 18, screenMode: "alternate-screen" })
const menu = new SessionMenu(setup.renderer, {