mirror/nanobot
1
0
Fork 0
mirror of https://github.com/HKUDS/nanobot.git synced 2026-08-07 01:48:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use try/finally in _extract_xlsx to prevent resource leak

Browse Source
This commit is contained in:
彭星杰 2026-04-21 16:16:27 +08:00 committed by Xubin Ren
parent a00beebd06
commit 46864b0911
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nanobot/utils/document.py
View File

@ -133,7 +133,8 @@ def _extract_docx(path: Path) -> str:
def _extract_xlsx(path: Path) -> str: def _extract_xlsx(path: Path) -> str:
"""Extract text from XLSX using openpyxl.""" """Extract text from XLSX using openpyxl."""
try: try:
with load_workbook(path, read_only=True, data_only=True) as wb: wb = load_workbook(path, read_only=True, data_only=True)
try:
sheets: list[str] = [] sheets: list[str] = []
for sheet_name in wb.sheetnames: for sheet_name in wb.sheetnames:
ws = wb[sheet_name] ws = wb[sheet_name]
@ -145,6 +146,8 @@ def _extract_xlsx(path: Path) -> str:
if rows: if rows:
sheets.append(f"--- Sheet: {sheet_name} ---\n" + "\n".join(rows)) sheets.append(f"--- Sheet: {sheet_name} ---\n" + "\n".join(rows))
return _truncate("\n\n".join(sheets), _MAX_TEXT_LENGTH) return _truncate("\n\n".join(sheets), _MAX_TEXT_LENGTH)
finally:
wb.close()
except Exception as e: except Exception as e:
logger.error("Failed to extract XLSX {}: {}", path, e) logger.error("Failed to extract XLSX {}: {}", path, e)
return f"[error: failed to extract XLSX: {e!s}]" return f"[error: failed to extract XLSX: {e!s}]"