From 9adcd3d923acd6b6b7d9756862d0901cec067351 Mon Sep 17 00:00:00 2001
From: "Aleksander W. Oleszkiewicz (Alek)"
 <aleksander.oleszkiewicz@auticon.com>
Date: Fri, 10 Jul 2026 13:01:59 +0200
Subject: [PATCH] adding tests to prevent regression

---
 tests/agent/test_dream.py | 47 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/tests/agent/test_dream.py b/tests/agent/test_dream.py
index 7b3f41e53..04d355b7b 100644
--- a/tests/agent/test_dream.py
+++ b/tests/agent/test_dream.py
@@ -654,6 +654,53 @@ class TestDreamCommitMessage:
             == "dream: x\n\nSOUL.md: +1 -0"
         )
 
+    def test_productive_gate_skips_commit_when_no_content_change(self, tmp_path):
+        """When no content files changed, there should be no auto_commit. 
+        In the old code, auto_commit ran unconditionally
+        in the finally block; now it only runs when productive is True."""
+        from unittest.mock import MagicMock
+
+        store = MemoryStore(tmp_path)
+        store.write_soul("# Soul")
+        store.write_memory("# Memory")
+        store.git.init()
+        store.git.auto_commit("initial")
+
+        assert store.dream_content_diff() == ""
+
+        original = store.git.auto_commit
+        store.git.auto_commit = MagicMock(wraps=original)
+
+        # Exact productive gate pattern from the cron handler (commands.py):
+        diff_body = store.dream_content_diff()
+        productive = bool(diff_body)  # git is initialized
+        if productive and store.git.is_initialized():
+            store.git.auto_commit("dream: periodic memory consolidation")
+
+        store.git.auto_commit.assert_not_called()
+
+    def test_productive_gate_allows_commit_on_content_change(self, tmp_path):
+        """The productive gate must perform auto_commit when content files changed."""
+        from unittest.mock import MagicMock
+
+        store = MemoryStore(tmp_path)
+        store.write_soul("# Soul")
+        store.write_memory("# Memory")
+        store.git.init()
+        store.git.auto_commit("initial")
+
+        store.write_memory("# Memory\n- Research notes")
+
+        original = store.git.auto_commit
+        store.git.auto_commit = MagicMock(wraps=original)
+
+        diff_body = store.dream_content_diff()
+        productive = bool(diff_body)
+        if productive and store.git.is_initialized():
+            store.git.auto_commit("dream: periodic memory consolidation")
+
+        store.git.auto_commit.assert_called_once()
+
 
 class TestDreamContentDiff:
     """The ground-truth signal that gates cursor advance and commit messages."""