From ae7618f4583ed9975ec1a9e34cfd8fbbc64fbd35 Mon Sep 17 00:00:00 2001
From: Xubin Ren <52506698+Re-bin@users.noreply.github.com>
Date: Wed, 2 Sep 2026 02:02:30 +0800
Subject: [PATCH] fix(webui): simplify unconfigured model badge

---
 .../components/thread/ModelPresetBadge.tsx    | 28 ++++++++-----------
 webui/src/tests/thread-shell.test.tsx         |  5 ++--
 2 files changed, 13 insertions(+), 20 deletions(-)

diff --git a/webui/src/components/thread/ModelPresetBadge.tsx b/webui/src/components/thread/ModelPresetBadge.tsx
index 143fff734..224610ee3 100644
--- a/webui/src/components/thread/ModelPresetBadge.tsx
+++ b/webui/src/components/thread/ModelPresetBadge.tsx
@@ -548,14 +548,15 @@ function PresetPill({
         zIndex: Math.round(scale * 100),
       }}
     >
-      <PresetProviderIcon
-        label={label}
-        modelDetail={modelDetail}
-        provider={inferredProvider}
-        needsSetup={needsSetup}
-        testId={needsSetup ? "composer-model-setup-icon" : `composer-model-logo${inferredProvider ? `-${inferredProvider}` : ""}`}
-        isHero={isHero}
-      />
+      {!needsSetup ? (
+        <PresetProviderIcon
+          label={label}
+          modelDetail={modelDetail}
+          provider={inferredProvider}
+          testId={`composer-model-logo${inferredProvider ? `-${inferredProvider}` : ""}`}
+          isHero={isHero}
+        />
+      ) : null}
       <span
         ref={labelRef}
         className={cn(
@@ -573,20 +574,16 @@ function PresetProviderIcon({
   label,
   modelDetail,
   provider,
-  needsSetup = false,
   testId,
   isHero,
 }: {
   label: string;
   modelDetail?: string | null;
   provider?: string | null;
-  needsSetup?: boolean;
   testId?: string;
   isHero: boolean;
 }) {
-  const inferredProvider = needsSetup
-    ? null
-    : provider || inferProviderFromModelName(modelDetail || label);
+  const inferredProvider = provider || inferProviderFromModelName(modelDetail || label);
   const brand = providerBrand(inferredProvider);
   const { logoUrl, onLogoError, onLogoLoad } = useLogoFallback(brand?.logoUrls);
   return (
@@ -594,14 +591,11 @@ function PresetProviderIcon({
       data-testid={testId}
       className={cn(
         "grid shrink-0 place-items-center",
-        needsSetup && "text-muted-foreground",
         isHero ? "h-4 w-4" : "h-[18px] w-[18px]",
       )}
       aria-hidden
     >
-      {needsSetup ? (
-        <Sparkles className={cn(isHero ? "h-3 w-3" : "h-3.5 w-3.5")} strokeWidth={1.8} />
-      ) : logoUrl ? (
+      {logoUrl ? (
         <img
           src={logoUrl}
           alt=""
diff --git a/webui/src/tests/thread-shell.test.tsx b/webui/src/tests/thread-shell.test.tsx
index ff7cda7f2..67905a92e 100644
--- a/webui/src/tests/thread-shell.test.tsx
+++ b/webui/src/tests/thread-shell.test.tsx
@@ -875,9 +875,8 @@ describe("ThreadShell", () => {
     );
 
     const badge = await screen.findByRole("button", { name: "Choose your AI" });
-    const setupIcon = screen.getByTestId("composer-model-setup-icon");
-    expect(setupIcon).toBeInTheDocument();
-    expect(setupIcon.parentElement).not.toHaveClass("border-amber-500/35");
+    expect(screen.queryByTestId("composer-model-setup-icon")).not.toBeInTheDocument();
+    expect(badge).not.toHaveClass("border-amber-500/35");
     expect(screen.queryByTestId("composer-model-logo-openai_codex")).not.toBeInTheDocument();
     fireEvent.click(badge);
     expect(await screen.findByRole("dialog", { name: "Choose your AI" })).toBeInTheDocument();