mirror/nanobot
1
0
Fork 0
mirror of https://github.com/HKUDS/nanobot.git synced 2026-08-07 01:48:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent): make detached exec portable on Windows

Browse Source
This commit is contained in:
Ubuntu 2026-06-28 11:05:10 +00:00
parent 1cd3431639
commit de9c5f03ae
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nanobot/agent/tools/shell.py
View File

@ -48,6 +48,7 @@ from nanobot.security.workspace_policy import is_path_within
from nanobot.utils.helpers import build_structured_output_summary from nanobot.utils.helpers import build_structured_output_summary
_IS_WINDOWS = sys.platform == "win32" _IS_WINDOWS = sys.platform == "win32"
_DETACHED_EXIT_GRACE_S = 1.0 if _IS_WINDOWS else 0.2
# Policy note appended to recoverable workspace-boundary guard errors. # Policy note appended to recoverable workspace-boundary guard errors.
@ -436,11 +437,7 @@ class ExecTool(Tool):
stdout=log_handle, stdout=log_handle,
stderr=log_handle, stderr=log_handle,
start_new_session=not _IS_WINDOWS, start_new_session=not _IS_WINDOWS,
creationflags=( creationflags=subprocess.CREATE_NEW_PROCESS_GROUP if _IS_WINDOWS else 0,
subprocess.CREATE_NEW_PROCESS_GROUP | subprocess.DETACHED_PROCESS
if _IS_WINDOWS
else 0
),
) )
except Exception as exc: except Exception as exc:
return f"Error starting detached command: {exc}" return f"Error starting detached command: {exc}"
@ -450,7 +447,7 @@ class ExecTool(Tool):
log_handle.close() log_handle.close()
try: try:
exit_code = await asyncio.wait_for(process.wait(), timeout=0.2) exit_code = await asyncio.wait_for(process.wait(), timeout=_DETACHED_EXIT_GRACE_S)
except asyncio.TimeoutError: except asyncio.TimeoutError:
return ( return (
"Detached process started.\n" "Detached process started.\n"