mirror/nanobot
1
0
Fork 0
mirror of https://github.com/HKUDS/nanobot.git synced 2026-08-06 17:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(memory): preserve Dream input integrity (#5114)

Browse Source
This commit is contained in:
chengyongru 2026-07-27 21:37:13 +08:00 committed by GitHub
parent e819b7eea4
commit f78ad59ed0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nanobot/agent/memory.py
View File

@ -589,7 +589,7 @@ class MemoryStore:
batch = entries[:max_entries] batch = entries[:max_entries]
history_text = "\n".join( history_text = "\n".join(
f"[{e['timestamp']}] {truncate_text(e['content'], 500)}" f"[{e['timestamp']}] {truncate_text(e['content'], 1000)}"
for e in batch for e in batch
) )
template = self._dream_template() template = self._dream_template()
@ -670,6 +670,7 @@ class MemoryStore:
tools.register(WriteFileTool( tools.register(WriteFileTool(
workspace=workspace, workspace=workspace,
allowed_dir=skills_dir, allowed_dir=skills_dir,
extra_write_allowed_files=editable_files,
file_states=file_states, file_states=file_states,
)) ))
return tools return tools

28
tests/agent/test_dream.py
View File

@ -127,15 +127,15 @@ class TestBuildDreamPrompt:
prompt, _ = result prompt, _ = result
assert "memory consolidation engine" in prompt assert "memory consolidation engine" in prompt
def test_truncates_long_entries(self, store): def test_truncates_long_entries_at_1000_chars(self, store):
long_content = "x" * 2000 long_content = "x" * 2000
store.append_history(long_content) store.append_history(long_content)
result = store.build_dream_prompt() result = store.build_dream_prompt()
assert result is not None assert result is not None
prompt, _ = result prompt, _ = result
# The full 2000 chars should not appear — truncated to 500
assert long_content not in prompt assert long_content not in prompt
assert "x" * 500 in prompt assert "x" * 1000 in prompt
assert "x" * 1001 not in prompt
def test_batches_oldest_unprocessed_entries_first(self, store): def test_batches_oldest_unprocessed_entries_first(self, store):
for i in range(25): for i in range(25):
@ -222,11 +222,20 @@ class TestDreamTools:
"new_text": "Precise", "new_text": "Precise",
}, },
) )
user_result = await tools.execute(
"write_file",
{
"path": "USER.md",
"content": "# User Profile\n\n- **Name**: Ada\n",
},
)
assert "Patch applied" in memory_result assert "Patch applied" in memory_result
assert "Successfully edited" in soul_result assert "Successfully edited" in soul_result
assert "Successfully wrote" in user_result
assert "Project Y active" in store.memory_file.read_text(encoding="utf-8") assert "Project Y active" in store.memory_file.read_text(encoding="utf-8")
assert "Precise" in store.soul_file.read_text(encoding="utf-8") assert "Precise" in store.soul_file.read_text(encoding="utf-8")
assert "**Name**: Ada" in store.user_file.read_text(encoding="utf-8")
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_dream_can_write_workspace_skills(self, store): async def test_dream_can_write_workspace_skills(self, store):
@ -306,9 +315,17 @@ class TestDreamTools:
"new_text": "2", "new_text": "2",
}, },
) )
history_write_result = await tools.execute(
"write_file",
{
"path": "memory/history.jsonl",
"content": "after\n",
},
)
assert "outside allowed directory" in history_result assert "outside allowed directory" in history_result
assert "outside allowed directory" in cursor_result assert "outside allowed directory" in cursor_result
assert "outside allowed directory" in history_write_result
assert store.history_file.read_text(encoding="utf-8") == "before\n" assert store.history_file.read_text(encoding="utf-8") == "before\n"
assert store._dream_cursor_file.read_text(encoding="utf-8") == "1" assert store._dream_cursor_file.read_text(encoding="utf-8") == "1"
@ -331,11 +348,10 @@ class TestDreamTools:
}, },
) )
user_result = await tools.execute( user_result = await tools.execute(
"edit_file", "write_file",
{ {
"path": "USER.md/evil.txt", "path": "USER.md/evil.txt",
"old_text": "", "content": "owned",
"new_text": "owned",
}, },
) )