from __future__ import annotations import json import subprocess import sys import time from pathlib import Path import pytest from nanobot.cli_apps.service import CliAppError, CliAppManager, CliAppsRuntimeConfig def _write_cache(path: Path, registry: dict) -> None: path.parent.mkdir(parents=True, exist_ok=True) path.write_text( json.dumps({"_cached_at": time.time(), "data": registry}), encoding="utf-8", ) def _manager(tmp_path: Path) -> CliAppManager: workspace = tmp_path / "workspace" workspace.mkdir() return CliAppManager( workspace=workspace, data_dir=tmp_path / "data", runtime=CliAppsRuntimeConfig(catalog_ttl_seconds=3600, install_timeout=5, run_timeout=5), ) def _seed_catalog(manager: CliAppManager) -> None: harness = { "meta": {"updated": "2026-04-16"}, "clis": [ { "name": "gimp", "display_name": "GIMP", "version": "1.0.0", "description": "Image editing", "category": "image", "requires": "Python 3.10+", "install_cmd": "pip install cli-anything-gimp", "entry_point": "cli-anything-gimp", "skill_md": "skills/cli-anything-gimp/SKILL.md", } ], } public = { "meta": {"updated": "2026-04-18"}, "clis": [ { "name": "gimp", "display_name": "GIMP", "description": "Public duplicate entry", }, { "name": "jimeng", "display_name": "Jimeng", "version": "latest", "description": "Script install", "category": "ai", "install_strategy": "script", "install_cmd": "curl -fsSL https://example.invalid/install.sh | bash", "entry_point": "dreamina", }, { "name": "feishu", "display_name": "Feishu/Lark CLI", "version": "latest", "description": "Official Lark CLI", "category": "communication", "package_manager": "npm", "npm_package": "@larksuite/cli", "install_cmd": "npm install -g @larksuite/cli", "entry_point": "lark-cli", }, { "name": "dify-workflow", "display_name": "Dify Workflow", "version": "latest", "description": "Run Dify workflows", "category": "ai", "install_cmd": "pip install cli-anything-dify-workflow", "entry_point": "cli-anything-dify-workflow", }, { "name": "shopify", "display_name": "Shopify CLI", "version": "latest", "description": "Shopify", "category": "web", "package_manager": "npm", "npm_package": "@shopify/cli", "install_cmd": "npm install -g @shopify/cli", "entry_point": "shopify", }, { "name": "clibrowser", "display_name": "clibrowser", "version": "latest", "description": "Cargo install", "category": "web", "install_cmd": "cargo install --git https://example.invalid/clibrowser.git", "entry_point": "clibrowser", }, { "name": "suno", "display_name": "Suno CLI", "version": "latest", "description": "python3 pip install", "category": "music", "package_manager": "pip", "install_strategy": "command", "install_cmd": "python3 -m pip install git+https://example.invalid/suno-cli.git", "uninstall_cmd": "python3 -m pip uninstall -y suno-cli", "entry_point": "suno", }, ], } _write_cache(manager._cache_path("harness"), harness) _write_cache(manager._cache_path("public"), public) def test_payload_merges_catalog_and_marks_unsupported_installs(tmp_path: Path) -> None: manager = _manager(tmp_path) _seed_catalog(manager) payload = manager.payload() assert payload["catalog_updated_at"] == "2026-04-18" apps = {app["name"]: app for app in payload["apps"]} assert set(apps) == { "clibrowser", "dify-workflow", "feishu", "gimp", "jimeng", "shopify", "suno", } assert apps["gimp"]["install_supported"] is True assert apps["gimp"]["source"] == "harness+public" assert apps["gimp"]["description"] == "Public duplicate entry" assert apps["clibrowser"]["install_supported"] is False assert apps["jimeng"]["install_supported"] is False assert apps["suno"]["install_supported"] is True assert apps["gimp"]["logo_url"] assert apps["dify-workflow"]["logo_url"] == "https://cdn.simpleicons.org/dify/155EEF" assert apps["feishu"]["logo_url"] == ( "https://www.google.com/s2/favicons?domain=larksuite.com&sz=64" ) assert apps["jimeng"]["logo_url"] == "https://cdn.simpleicons.org/bytedance/3C8CFF" assert apps["clibrowser"]["logo_url"] == ( "https://www.google.com/s2/favicons?domain=github.com/allthingssecurity/clibrowser&sz=64" ) def test_install_dispatches_safe_pip_and_installs_skill( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, ) -> None: manager = _manager(tmp_path) _seed_catalog(manager) calls: list[list[str]] = [] def fake_run(argv: list[str], *, timeout: int) -> subprocess.CompletedProcess[str]: calls.append(argv) return subprocess.CompletedProcess(argv, 0, stdout="ok", stderr="") monkeypatch.setattr(manager, "_run_argv", fake_run) monkeypatch.setattr( manager, "_fetch_skill_content", lambda app: "---\nname: cli-anything-gimp\ndescription: GIMP\n---\n# GIMP\n", ) payload = manager.install("gimp") assert calls == [[sys.executable, "-m", "pip", "install", "cli-anything-gimp"]] assert payload["last_action"]["ok"] is True installed = json.loads(manager.installed_path.read_text(encoding="utf-8"))["apps"] assert installed["gimp"]["entry_point"] == "cli-anything-gimp" skill = manager.workspace / "skills" / "cli-app-gimp" / "SKILL.md" assert skill.is_file() assert 'run_cli_app` tool with `name="gimp"' in skill.read_text(encoding="utf-8") def test_installed_state_writes_atomically_without_temp_leftovers(tmp_path: Path) -> None: manager = _manager(tmp_path) manager._save_installed({"gimp": {"entry_point": "cli-anything-gimp"}}) manager._save_installed({"zoom": {"entry_point": "cli-anything-zoom"}}) installed = json.loads(manager.installed_path.read_text(encoding="utf-8"))["apps"] assert set(installed) == {"zoom"} assert not list(manager.installed_path.parent.glob(".installed.json.*.tmp")) def test_fetch_skill_content_rejects_untrusted_urls( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, ) -> None: manager = _manager(tmp_path) def fail_get(*args, **kwargs): raise AssertionError("untrusted skill URL should not be fetched") monkeypatch.setattr("nanobot.cli_apps.service.httpx.get", fail_get) assert manager._fetch_skill_content({ "name": "evil", "skill_md": "https://example.com/SKILL.md", }) is None assert manager._fetch_skill_content({ "name": "evil", "skill_md": "skills/../evil/SKILL.md", }) is None def test_fetch_skill_content_allows_cli_anything_raw_skill_url( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, ) -> None: manager = _manager(tmp_path) seen: list[str] = [] class Response: text = "---\nname: cli-app-test\ndescription: Test\n---\n# Test\n" @staticmethod def raise_for_status() -> None: return None def fake_get(url: str, **kwargs): seen.append(url) return Response() monkeypatch.setattr("nanobot.cli_apps.service.httpx.get", fake_get) content = manager._fetch_skill_content({ "name": "gimp", "skill_md": "https://raw.githubusercontent.com/HKUDS/CLI-Anything/main/skills/cli-anything-gimp/SKILL.md", }) assert content and "# Test" in content assert seen == [ "https://raw.githubusercontent.com/HKUDS/CLI-Anything/main/skills/cli-anything-gimp/SKILL.md" ] def test_uninstall_removes_installed_state_and_generated_skill( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, ) -> None: manager = _manager(tmp_path) _seed_catalog(manager) manager._save_installed({"gimp": {"entry_point": "cli-anything-gimp"}}) skill_dir = manager.workspace / "skills" / "cli-app-gimp" skill_dir.mkdir(parents=True) (skill_dir / "SKILL.md").write_text("# GIMP\n", encoding="utf-8") monkeypatch.setattr( manager, "_run_argv", lambda argv, *, timeout: subprocess.CompletedProcess(argv, 0, stdout="ok", stderr=""), ) payload = manager.uninstall("gimp") assert payload["last_action"]["ok"] is True assert "gimp" not in json.loads(manager.installed_path.read_text(encoding="utf-8"))["apps"] assert not skill_dir.exists() def test_uninstall_uses_safe_python_m_pip_uninstall_command( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, ) -> None: manager = _manager(tmp_path) _seed_catalog(manager) manager._save_installed({"suno": {"entry_point": "suno"}}) calls: list[list[str]] = [] def fake_run(argv: list[str], *, timeout: int) -> subprocess.CompletedProcess[str]: calls.append(argv) return subprocess.CompletedProcess(argv, 0, stdout="ok", stderr="") monkeypatch.setattr(manager, "_run_argv", fake_run) payload = manager.uninstall("suno") assert calls == [[sys.executable, "-m", "pip", "uninstall", "-y", "suno-cli"]] assert payload["last_action"]["ok"] is True def test_mentioned_installed_apps_only_returns_installed_mentions(tmp_path: Path) -> None: manager = _manager(tmp_path) manager._save_installed( { "gimp": {"entry_point": "cli-anything-gimp", "source": "harness"}, "zoom": {"entry_point": "cli-anything-zoom", "source": "public"}, } ) mentions = manager.mentioned_installed_apps("use @zoom and @krita, then @GIMP") assert mentions == [ { "name": "zoom", "entry_point": "cli-anything-zoom", "source": "public", "skill": "skills/cli-app-zoom/SKILL.md", "tool": "run_cli_app", }, { "name": "gimp", "entry_point": "cli-anything-gimp", "source": "harness", "skill": "skills/cli-app-gimp/SKILL.md", "tool": "run_cli_app", }, ] def test_install_rejects_unknown_and_script_strategy(tmp_path: Path) -> None: manager = _manager(tmp_path) _seed_catalog(manager) with pytest.raises(CliAppError, match="not found"): manager.install("missing") with pytest.raises(CliAppError, match="unsupported"): manager.install("jimeng") def test_run_installed_cli_uses_argv_without_shell( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, ) -> None: manager = _manager(tmp_path) _seed_catalog(manager) resolved = str(tmp_path / "bin" / "cli-anything-gimp") monkeypatch.setattr( "nanobot.cli_apps.service.shutil.which", lambda entry: resolved if entry == "cli-anything-gimp" else None, ) def fake_run(argv: list[str], **kwargs: object) -> subprocess.CompletedProcess[str]: assert "shell" not in kwargs or kwargs["shell"] is False return subprocess.CompletedProcess( argv, 0, stdout="ARGS=" + repr(argv[1:]), stderr="", ) monkeypatch.setattr("nanobot.cli_apps.service.subprocess.run", fake_run) manager._save_installed( { "gimp": { "version": "1.0.0", "entry_point": "cli-anything-gimp", "source": "harness", "strategy": "pip", } } ) result = manager.run("gimp", ["project", "list"], json_output=True) assert "CLI app 'gimp' exited 0" in result assert "['--json', 'project', 'list']" in result def test_run_blocks_working_dir_outside_workspace(tmp_path: Path) -> None: manager = _manager(tmp_path) _seed_catalog(manager) manager._save_installed({"gimp": {"entry_point": "cli-anything-gimp"}}) with pytest.raises(CliAppError, match="outside the configured workspace"): manager.run("gimp", working_dir="/etc", restrict_to_workspace=True)