nanobot

mirror of https://github.com/HKUDS/nanobot.git synced 2026-04-15 15:39:47 +00:00

History

bahtya fa98524944 fix(channels): prevent retry amplification and silent message loss across channels

Audited all channel implementations for overly broad exception handling
that causes retry amplification or silent message loss during network
errors. This is the same class of bug as #3050 (Telegram _send_text).

Fixes by channel:

Telegram (send_delta):
- _stream_end path used except Exception for HTML edit fallback
- Network errors (TimedOut, NetworkError) triggered redundant plain
  text edit, doubling connection demand during pool exhaustion
- Changed to except BadRequest, matching the _send_text fix

Discord:
- send() caught all exceptions without re-raising
- ChannelManager._send_with_retry() saw successful return, never retried
- Messages silently dropped on any send failure
- Added raise after error logging

DingTalk:
- _send_batch_message() returned False on all exceptions including
  network errors — no retry, fallback text sent unnecessarily
- _read_media_bytes() and _upload_media() swallowed transport errors,
  causing _send_media_ref() to cascade through doomed fallback attempts
- Added except httpx.TransportError handlers that re-raise immediately

WeChat:
- Media send failure triggered text fallback even for network errors
- During network issues: 3×(media + text) = 6 API calls per message
- Added specific catches: TimeoutException/TransportError re-raise,
  5xx HTTPStatusError re-raises, 4xx falls back to text

QQ:
- _send_media() returned False on all exceptions
- Network errors triggered fallback text instead of retry
- Added except (aiohttp.ClientError, OSError) that re-raises

Tests: 331 passed (283 existing + 48 new across 5 channel test files)

Fixes: #3054
Related: #3050, #3053

2026-04-13 00:30:45 +08:00

test_base_channel.py

refactor(tests): optimize unit test structure

2026-03-24 15:12:22 +08:00

test_channel_manager_delta_coalescing.py

fix(channel): stop delta coalescing at stream boundaries

2026-03-27 21:43:57 +08:00

test_channel_plugins.py

fix(restart): show restart completion with elapsed time across channels

2026-04-04 02:21:42 +08:00

test_dingtalk_channel.py

fix(channels): prevent retry amplification and silent message loss across channels