mirror of
https://github.com/HKUDS/nanobot.git
synced 2026-05-20 00:22:31 +00:00
* feat(long-task): add LongTaskTool for multi-step agent tasks
Implements a meta-ReAct loop where long-running tasks are broken into
sequential subagent steps, each starting fresh with the original goal
and progress from the previous step. This prevents context drift when
agents work on complex, multi-step tasks.
- Extract build_tool_registry() from SubagentManager for reuse
- Add run_step() for synchronous subagent execution (no bus announcement)
- Add HandoffTool and CompleteTool as signal mechanisms via shared dict
- Add LongTaskTool orchestrator with simplified prompt (8 iterations/step)
- Register LongTaskTool in main agent loop
- Add _extract_handoff_from_messages fallback for robustness
* fix(long-task): add debug logging for step-level observability
* feat(long-task): major overhaul with structured handoffs, validation, and observability
- Structured HandoffState: HandoffTool now accepts files_created,
files_modified, next_step_hint, and verification fields instead of
a plain string. Progress is passed between steps as structured data.
- Completion validation round: After complete() is called, a dedicated
validator step runs to verify the claim against the original goal.
If validation fails, the task continues rather than returning
a false completion.
- Dynamic prompt system: 3 Jinja2 templates (step_start, step_middle,
step_final) selected based on step number. Final steps get tighter
budget and stronger "wrap up" guidance.
- Automatic file change tracking: Extracts write_file/edit_file events
from tool_events and injects them into the next step's context if
the subagent forgot to report them explicitly.
- Budget tracking & adaptive strategy: Cumulative token usage is tracked
across steps. Per-step tool budget drops from 8 to 4 in the last
two steps to force handoff/completion.
- Crash retry with graceful degradation: A step that crashes is retried
once. Persistent crashes terminate the task and return partial progress.
- Full observability hooks for future WebUI integration:
- set_hooks() with on_step_start, on_step_complete, on_handoff,
on_validation_started, on_validation_passed, on_validation_failed,
on_task_complete, on_task_error, and catch-all on_event.
- Readable state properties: current_step, total_steps, status,
last_handoff, cumulative_usage, goal.
- inject_correction() allows external code to send user corrections
that are injected into the next step's prompt.
- run_step() accepts optional max_iterations for dynamic budget control.
All 27 long-task tests and 11 subagent tests pass.
* test(long-task): add boundary tests and fix race conditions
- Add 7 edge-case tests: validation crash resilience, hook exception safety, mid-run correction injection, FIFO correction ordering, explicit file changes overriding auto-detection, final budget for max_steps=1, and dynamic budget switching boundaries
- Fix assertion in test_long_task_completes_after_multiple_handoffs to match exact prompt format
- Remove asyncio timing hack from test_state_exposure
- Add asyncio.sleep(0) yield in test_inject_correction_during_execution to prevent race between signal injection and step continuation
- All 34 tests passing
* fix(long-task): address code review findings
- Declare _scopes = {"core"} explicitly to prevent recursive nesting in subagent scope
- Document fragile coupling in _extract_file_changes: path extraction depends on
write_file/edit_file detail format; add debug log for unexpected formats
- Align final-template threshold (max_steps - 2) with budget switch threshold
- Eliminate hasattr(self, "_state") in _reset_state by initializing in __init__
* fix(long-task): honor final signal and file tracking
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(long-task): improve prompt structure and agent contract
- Expand LongTaskTool.description to instruct parent agent on goal
construction, return value semantics, and how to handle results.
- Expand CompleteTool.description to emphasize that the summary IS the
final answer returned to the parent agent.
- Prefix validated return value with an explicit "final answer" directive
to stop parent agent from re-running work.
- Redesign step_start.md: Step 1 is now explicitly for exploration,
planning, and skeleton-building. complete() is discouraged.
- Remove bulky payload debug logging from _emit(); add targeted
info/warning/error logs at key state transitions instead.
- Add signal_type to HandoffState for cleaner signal detection.
* test(long-task): expect wrapped completion message after validation
Align assertions with LongTaskTool final return shape on main.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(webui): turn timing strip, latency, and session-switch restore
- Agent loop: publish goal_status run/idle for WebSocket turns; attach
wall-clock latency_ms on turn_end and persisted assistant metadata.
- WebSocket channel: forward goal_status and latency fields to clients.
- NanobotClient: track goal_status started_at per chat without requiring
onChat; useNanobotStream restores run strip when returning to a chat.
- Thread UI: composer/shell viewport hooks for run duration and latency;
format helpers and i18n strings.
- MessageBubble: drop trailing StreamCursor (layout artifact vs block markdown).
- Builtin / tests: model command coverage, websocket and loop tests.
Covers multi-session UX and round-trip timing visibility for the WebUI.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix: keep message-tool file attachments after canonical history hydrate
- MessageTool records per-turn media paths delivered to the active chat.
- nanobot.utils.session_attachments stages out-of-media-root files and
merges into the last assistant message before save (loop stays a thin call).
- WebUI MediaCell: use a signed URL as a real download link when present.
Fixes attachments flashing then vanishing on turn_end when paths lived
outside get_media_dir (e.g. workspace files).
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(webui): agent activity cluster, stable keys, LTR sheen labels
- Group reasoning and tool traces in AgentActivityCluster with i18n summaries
- Stabilize React list keys for activity clusters (first message id anchor)
- Replace background-clip shimmer with overlay sheen for streaming labels
- ThreadMessages/MessageList integration and locale strings
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(webui): render assistant reasoning with Markdown + deferred stream
- Use MarkdownText for ReasoningBubble body (same GFM/KaTeX path as replies)
- Apply muted/italic prose tokens so thinking stays visually subordinate
- useDeferredValue while reasoningStreaming to ease parser work during deltas
- Preload markdown chunk when trace opens; add regression test with preloaded renderer
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(webui): default-collapse agent activity cluster while Working
Outer fold no longer auto-expands during isTurnStreaming; user opens to see traces.
Header sheen and live summary unchanged.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(long_task): cumulative run history, file union, and prompt tuning
Inject cross-step summaries and merged file paths into middle/final step
templates so chains do not lose early context. Strip the last run-history
block when it duplicates Previous Progress to save tokens. Add optional
cumulative_prompt_max_chars and cumulative_step_body_max_chars parameters
with clamped defaults.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(webui): session switch keeps in-flight thread and replays buffered WS
Save the prior chat message list to the per-chat cache in a layout effect
when chatId changes (before stale writes could corrupt another chat).
Skip one post-switch layout cache tick so we do not snapshot the wrong tab.
Buffer inbound events per chat_id when no onChat subscriber is registered
(e.g. user focused another session) and drain on resubscribe up to a cap,
so streaming deltas are not lost while off-tab.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(webui): snap thread scroll to bottom on session open (no smooth glide)
Use scroll-behavior auto on the viewport, instant programmatic scroll when
following new messages and on scrollToBottomSignal. Keep smooth only for
the explicit scroll-to-bottom button.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(webui): respect manual scroll-up after opening a session
Track when the user leaves the bottom with a ref and skip ResizeObserver
and deferred bottom snaps until they return or the conversation is reset.
Remove the time-based force-bottom window that overrode atBottom.
Multi-frame scrollToBottom honours the same guard unless force (scroll button).
Co-authored-by: Cursor <cursoragent@cursor.com>
* Publish long_task UI snapshots on outbound metadata
- Add OUTBOUND_META_AGENT_UI (_agent_ui) for channel-agnostic structured state
- LongTaskTool publishes {kind: long_task, data: snapshot} on the bus with _progress
- WebSocket send forwards metadata as agent_ui for WebUI clients
- Tests for bus payload, WS frame, and progress assertions
- Fix loop progress tests: ignore _goal_status in streaming final filter and
avoid brittle outbound[-1] ordering after goal status idle messages
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat: WebUI long_task activity card and resilient history merge
Add optional ui_summary to the long_task tool for one-line UI labels. Stream
long_task agent_ui into a dedicated message row with timeline, markdown peek,
and a right sheet for details. Merge canonical history after turn_end while
re-inserting long_task rows before the final assistant reply. Collapse
duplicate task_start/step_start steps in the timeline and extend i18n.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor: align long_task with thread_goal and drop orchestrator UI
- Persist sustained objectives via session metadata (long_task / complete_goal); no subagent wiring or tool-driven agent_ui payloads.\n- Remove WebUI long-task activity UI, types, and translations; history merge preserves trace replay only, with legacy long_task rows normalized to traces.\n- Drop long_task prompt templates and get_long_task_run_dir; add webui thread disk helper for gateway persistence tests.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(agent): thread goal runtime context, tools, and skill
- Add thread_goal_state helper and mirror active objectives into Runtime Context
- Wire loop/context/memory/events as needed for goal metadata in turns
- Expand long_task / complete_goal semantics (pivot/cancel/honest recap)
- Add always-on thread-goal SKILL.md; align /goal command prompt
- Tests for context builder and thread goal state
- Remove unused webui ChatPane component
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(thread-goal): add websocket snapshot helper and publish goal updates from long_task
Introduce thread_goal_ws_blob for bounded JSON snapshots, attach snapshots to
websocket turn_end metadata in AgentLoop, and let long_task fan-out dedicated
thread_goal frames on the websocket channel after persisting session metadata.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(channels): websocket thread_goal frames, turn_end replay, and session API scrub for subagent inject
Emit thread_goal events and optional thread_goal on turn_end; scrub persisted
subagent announce blobs on GET /api/sessions/.../messages and shorten session
list previews so WebUI does not surface full Task/Summarize scaffolding.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(webui): merge ephemeral traces per user turn when reconciling canonical history
Preserve disk/live trace rows inside the matching user–assistant segment instead
of stacking every trace before the final assistant reply (fixes inflated tool
counts after refresh or session switch).
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(webui): show assistant reply copy only on the last slice before the next user turn
Avoid duplicate copy affordances on intermediate assistant bubbles that precede
more agent activity in the same turn (tools or further assistant text).
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(webui): thread_goal stream plumbing, composer goal strip, sky glow, and client-side subagent scrub projection
Track thread_goal and turn_goal snapshots in NanobotClient, hydrate React state
from thread_goal frames and turn_end, surface objective/elapsed in the composer,
add breathing sky halo CSS while goals are active, mirror server scrub logic on
history hydration and webui_thread snapshots, and extend tests/client mocks.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(channels): add Slack Socket Mode connect timeout with actionable timeout errors
Abort hung websockets.connect handshakes after a bounded wait, log REST-vs-WSS
guidance, surface RuntimeError to channel startup, and log successful WSS setup.
Co-authored-by: Cursor <cursoragent@cursor.com>
* webui: expand thread goal in composer bottom sheet
Add ChevronUp control on the run/goal strip that opens a bottom Sheet
with full ui_summary and objective. Inline preview logic in RunElapsedStrip,
add i18n strings across locales, and a composer unit test.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(webui): widen dedupeToolCallsForUi input for session API typing
fetchSessionMessages types tool_calls as unknown; accept unknown so tsc
build passes when passing message.tool_calls through.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(agent): extract WebSocket turn run status to webui_turn_helpers
* refactor(skills): rename thread-goal to long-task and document idempotent goals
* feat(skills): rename sustained-goal skill to long-goal and tighten long_task guidance
* chore: remove unused subagent/context/router helpers
* feat(session): rename sustained goal to goal_state and align WS/WebUI
- Move helpers from agent/thread_goal_state to session/goal_state:
GOAL_STATE_KEY, goal_state_runtime_lines, goal_state_ws_blob, parse_goal_state.
- Session metadata now uses "goal_state"; still read legacy "thread_goal";
long_task writes drop the legacy key after save.
- WebSocket: event/field goal_state, _goal_state_sync; turn_end carries goal_state;
accept legacy _thread_goal_sync/thread_goal inbound metadata for dispatch.
- WebUI: GoalStateWsPayload, goalState hook/client props, i18n keys goalState*.
- Runtime Context copy uses "Goal (active):" instead of "Thread goal".
* feat(agent): stream Anthropic thinking deltas and fix stream idle timeout
* refactor(webui): transcript jsonl as sole timeline source
* fix(agent): reject mismatched WS message chat_id and stream reasoning deltas
* feat(webui): hydrate sustained goal and run timer after websocket subscribe
* chore(webui,websocket): remove unused fetch helpers and legacy thread_goal WS paths
* Raise default max_tokens and context window in agent schema.
Align AgentDefaults and ModelPresetConfig with typical Claude-scale usage
(32k completion budget, 256k context window) and update migration tests.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(gateway): bootstrap prefers in-memory model; clarify websocket naming
* fix(websocket): websocket _handle_message passes is_dm; refresh /status test expectations
---------
Co-authored-by: chengyongru <2755839590@qq.com>
Co-authored-by: chengyongru <chengyongru.ai@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
473 lines
19 KiB
Python
473 lines
19 KiB
Python
"""Channel manager for coordinating chat channels."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import hashlib
|
|
from collections.abc import Callable
|
|
from contextlib import suppress
|
|
from pathlib import Path
|
|
from typing import TYPE_CHECKING, Any
|
|
|
|
from loguru import logger
|
|
|
|
from nanobot.bus.events import OutboundMessage
|
|
from nanobot.bus.queue import MessageBus
|
|
from nanobot.channels.base import BaseChannel
|
|
from nanobot.config.schema import Config
|
|
from nanobot.utils.restart import consume_restart_notice_from_env, format_restart_completed_message
|
|
|
|
if TYPE_CHECKING:
|
|
from nanobot.session.manager import SessionManager
|
|
|
|
|
|
def _default_webui_dist() -> Path | None:
|
|
"""Return the absolute path to the bundled webui dist directory if it exists."""
|
|
try:
|
|
import nanobot.web as web_pkg # type: ignore[import-not-found]
|
|
except ImportError:
|
|
return None
|
|
candidate = Path(web_pkg.__file__).resolve().parent / "dist"
|
|
return candidate if candidate.is_dir() else None
|
|
|
|
|
|
# Retry delays for message sending (exponential backoff: 1s, 2s, 4s)
|
|
_SEND_RETRY_DELAYS = (1, 2, 4)
|
|
|
|
_BOOL_CAMEL_ALIASES: dict[str, str] = {
|
|
"send_progress": "sendProgress",
|
|
"send_tool_hints": "sendToolHints",
|
|
"show_reasoning": "showReasoning",
|
|
}
|
|
|
|
class ChannelManager:
|
|
"""
|
|
Manages chat channels and coordinates message routing.
|
|
|
|
Responsibilities:
|
|
- Initialize enabled channels (Telegram, WhatsApp, etc.)
|
|
- Start/stop channels
|
|
- Route outbound messages
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
config: Config,
|
|
bus: MessageBus,
|
|
*,
|
|
session_manager: "SessionManager | None" = None,
|
|
webui_runtime_model_name: Callable[[], str | None] | None = None,
|
|
):
|
|
self.config = config
|
|
self.bus = bus
|
|
self._session_manager = session_manager
|
|
self._webui_runtime_model_name = webui_runtime_model_name
|
|
self.channels: dict[str, BaseChannel] = {}
|
|
self._dispatch_task: asyncio.Task | None = None
|
|
self._origin_reply_fingerprints: dict[tuple[str, str, str], str] = {}
|
|
|
|
self._init_channels()
|
|
|
|
def _init_channels(self) -> None:
|
|
"""Initialize channels discovered via pkgutil scan + entry_points plugins."""
|
|
from nanobot.channels.registry import discover_all
|
|
|
|
transcription_provider = self.config.channels.transcription_provider
|
|
transcription_key = self._resolve_transcription_key(transcription_provider)
|
|
transcription_base = self._resolve_transcription_base(transcription_provider)
|
|
transcription_language = self.config.channels.transcription_language
|
|
|
|
for name, cls in discover_all().items():
|
|
section = getattr(self.config.channels, name, None)
|
|
if section is None:
|
|
continue
|
|
enabled = (
|
|
section.get("enabled", False)
|
|
if isinstance(section, dict)
|
|
else getattr(section, "enabled", False)
|
|
)
|
|
if not enabled:
|
|
continue
|
|
try:
|
|
kwargs: dict[str, Any] = {}
|
|
# Only the WebSocket channel currently hosts the embedded webui
|
|
# surface; other channels stay oblivious to these knobs.
|
|
if cls.name == "websocket":
|
|
if self._session_manager is not None:
|
|
kwargs["session_manager"] = self._session_manager
|
|
static_path = _default_webui_dist()
|
|
if static_path is not None:
|
|
kwargs["static_dist_path"] = static_path
|
|
if self._webui_runtime_model_name is not None:
|
|
kwargs["runtime_model_name"] = self._webui_runtime_model_name
|
|
channel = cls(section, self.bus, **kwargs)
|
|
channel.transcription_provider = transcription_provider
|
|
channel.transcription_api_key = transcription_key
|
|
channel.transcription_api_base = transcription_base
|
|
channel.transcription_language = transcription_language
|
|
channel.send_progress = self._resolve_bool_override(
|
|
section, "send_progress", self.config.channels.send_progress,
|
|
)
|
|
channel.send_tool_hints = self._resolve_bool_override(
|
|
section, "send_tool_hints", self.config.channels.send_tool_hints,
|
|
)
|
|
channel.show_reasoning = self._resolve_bool_override(
|
|
section, "show_reasoning", self.config.channels.show_reasoning,
|
|
)
|
|
self.channels[name] = channel
|
|
logger.info("{} channel enabled", cls.display_name)
|
|
except Exception as e:
|
|
logger.warning("{} channel not available: {}", name, e)
|
|
|
|
self._validate_allow_from()
|
|
|
|
def _resolve_transcription_key(self, provider: str) -> str:
|
|
"""Pick the API key for the configured transcription provider."""
|
|
try:
|
|
if provider == "openai":
|
|
return self.config.providers.openai.api_key
|
|
return self.config.providers.groq.api_key
|
|
except AttributeError:
|
|
return ""
|
|
|
|
def _resolve_transcription_base(self, provider: str) -> str:
|
|
"""Pick the API base URL for the configured transcription provider."""
|
|
try:
|
|
if provider == "openai":
|
|
return self.config.providers.openai.api_base or ""
|
|
return self.config.providers.groq.api_base or ""
|
|
except AttributeError:
|
|
return ""
|
|
|
|
def _validate_allow_from(self) -> None:
|
|
for name, ch in self.channels.items():
|
|
cfg = ch.config
|
|
if isinstance(cfg, dict):
|
|
if "allow_from" in cfg:
|
|
allow = cfg.get("allow_from")
|
|
else:
|
|
allow = cfg.get("allowFrom")
|
|
else:
|
|
allow = getattr(cfg, "allow_from", None)
|
|
if allow is None:
|
|
# allowFrom omitted → pairing-only mode. Unapproved senders
|
|
# receive a pairing code instead of being silently ignored.
|
|
logger.info(
|
|
'"{}" has no allowFrom; unapproved users will receive a pairing code',
|
|
name,
|
|
)
|
|
|
|
def _should_send_progress(self, channel_name: str, *, tool_hint: bool = False) -> bool:
|
|
"""Return whether progress (or tool-hints) may be sent to *channel_name*."""
|
|
ch = self.channels.get(channel_name)
|
|
if ch is None:
|
|
logger.warning("Progress check for unknown channel: {}", channel_name)
|
|
return False
|
|
return ch.send_tool_hints if tool_hint else ch.send_progress
|
|
|
|
def _resolve_bool_override(self, section: Any, key: str, default: bool) -> bool:
|
|
"""Return *key* from *section* if it is a bool, otherwise *default*.
|
|
|
|
For dict configs also checks the camelCase alias (e.g. ``sendProgress``
|
|
for ``send_progress``) so raw JSON/TOML configs work alongside
|
|
Pydantic models.
|
|
"""
|
|
if isinstance(section, dict):
|
|
value = section.get(key)
|
|
if value is None:
|
|
camel = _BOOL_CAMEL_ALIASES.get(key)
|
|
if camel:
|
|
value = section.get(camel)
|
|
return value if isinstance(value, bool) else default
|
|
value = getattr(section, key, None)
|
|
return value if isinstance(value, bool) else default
|
|
|
|
async def _start_channel(self, name: str, channel: BaseChannel) -> None:
|
|
"""Start a channel and log any exceptions."""
|
|
try:
|
|
await channel.start()
|
|
except Exception:
|
|
logger.exception("Failed to start channel {}", name)
|
|
|
|
async def start_all(self) -> None:
|
|
"""Start all channels and the outbound dispatcher."""
|
|
if not self.channels:
|
|
logger.warning("No channels enabled")
|
|
return
|
|
|
|
# Start outbound dispatcher
|
|
self._dispatch_task = asyncio.create_task(self._dispatch_outbound())
|
|
|
|
# Start channels
|
|
tasks = []
|
|
for name, channel in self.channels.items():
|
|
logger.info("Starting {} channel...", name)
|
|
tasks.append(asyncio.create_task(self._start_channel(name, channel)))
|
|
|
|
self._notify_restart_done_if_needed()
|
|
|
|
# Wait for all to complete (they should run forever)
|
|
await asyncio.gather(*tasks, return_exceptions=True)
|
|
|
|
def _notify_restart_done_if_needed(self) -> None:
|
|
"""Send restart completion message when runtime env markers are present."""
|
|
notice = consume_restart_notice_from_env()
|
|
if not notice:
|
|
return
|
|
target = self.channels.get(notice.channel)
|
|
if not target:
|
|
return
|
|
asyncio.create_task(self._send_with_retry(
|
|
target,
|
|
OutboundMessage(
|
|
channel=notice.channel,
|
|
chat_id=notice.chat_id,
|
|
content=format_restart_completed_message(notice.started_at_raw),
|
|
metadata=dict(notice.metadata or {}),
|
|
),
|
|
))
|
|
|
|
async def stop_all(self) -> None:
|
|
"""Stop all channels and the dispatcher."""
|
|
logger.info("Stopping all channels...")
|
|
|
|
# Stop dispatcher
|
|
if self._dispatch_task:
|
|
self._dispatch_task.cancel()
|
|
with suppress(asyncio.CancelledError):
|
|
await self._dispatch_task
|
|
|
|
# Stop all channels
|
|
for name, channel in self.channels.items():
|
|
try:
|
|
await channel.stop()
|
|
logger.info("Stopped {} channel", name)
|
|
except Exception:
|
|
logger.exception("Error stopping {}", name)
|
|
|
|
@staticmethod
|
|
def _fingerprint_content(content: str) -> str:
|
|
normalized = " ".join(content.split())
|
|
return hashlib.sha1(normalized.encode("utf-8")).hexdigest() if normalized else ""
|
|
|
|
def _should_suppress_outbound(self, msg: OutboundMessage) -> bool:
|
|
metadata = msg.metadata or {}
|
|
if metadata.get("_progress"):
|
|
return False
|
|
fingerprint = self._fingerprint_content(msg.content)
|
|
if not fingerprint:
|
|
return False
|
|
|
|
origin_message_id = metadata.get("origin_message_id")
|
|
if isinstance(origin_message_id, str) and origin_message_id:
|
|
key = (msg.channel, msg.chat_id, origin_message_id)
|
|
if self._origin_reply_fingerprints.get(key) == fingerprint:
|
|
return True
|
|
self._origin_reply_fingerprints[key] = fingerprint
|
|
|
|
message_id = metadata.get("message_id")
|
|
if isinstance(message_id, str) and message_id:
|
|
key = (msg.channel, msg.chat_id, message_id)
|
|
self._origin_reply_fingerprints[key] = fingerprint
|
|
|
|
return False
|
|
|
|
async def _dispatch_outbound(self) -> None:
|
|
"""Dispatch outbound messages to the appropriate channel."""
|
|
logger.info("Outbound dispatcher started")
|
|
|
|
# Buffer for messages that couldn't be processed during delta coalescing
|
|
# (since asyncio.Queue doesn't support push_front)
|
|
pending: list[OutboundMessage] = []
|
|
|
|
while True:
|
|
try:
|
|
# First check pending buffer before waiting on queue
|
|
if pending:
|
|
msg = pending.pop(0)
|
|
else:
|
|
msg = await asyncio.wait_for(
|
|
self.bus.consume_outbound(),
|
|
timeout=1.0
|
|
)
|
|
|
|
if (
|
|
msg.metadata.get("_reasoning_delta")
|
|
or msg.metadata.get("_reasoning_end")
|
|
or msg.metadata.get("_reasoning")
|
|
):
|
|
# Reasoning rides its own plugin channel: only delivered
|
|
# when the destination channel opts in via ``show_reasoning``
|
|
# and overrides the streaming primitives. Channels without
|
|
# a low-emphasis UI affordance keep the base no-op and the
|
|
# content silently drops here. ``_reasoning`` (one-shot)
|
|
# is accepted for backward compatibility with hooks that
|
|
# haven't migrated to delta/end yet.
|
|
channel = self.channels.get(msg.channel)
|
|
if channel is not None and channel.show_reasoning:
|
|
await self._send_with_retry(channel, msg)
|
|
continue
|
|
|
|
if msg.metadata.get("_progress"):
|
|
if msg.metadata.get("_tool_hint") and not self._should_send_progress(
|
|
msg.channel, tool_hint=True,
|
|
):
|
|
continue
|
|
if not msg.metadata.get("_tool_hint") and not self._should_send_progress(
|
|
msg.channel, tool_hint=False,
|
|
):
|
|
continue
|
|
|
|
if msg.metadata.get("_retry_wait"):
|
|
continue
|
|
|
|
if (
|
|
msg.metadata.get("_runtime_model_updated")
|
|
and msg.channel == "websocket"
|
|
and "websocket" not in self.channels
|
|
):
|
|
continue
|
|
|
|
# Coalesce consecutive _stream_delta messages for the same (channel, chat_id)
|
|
# to reduce API calls and improve streaming latency
|
|
if msg.metadata.get("_stream_delta") and not msg.metadata.get("_stream_end"):
|
|
msg, extra_pending = self._coalesce_stream_deltas(msg)
|
|
pending.extend(extra_pending)
|
|
|
|
channel = self.channels.get(msg.channel)
|
|
if channel:
|
|
# Duplicate suppression is scoped to a known source message
|
|
# so repeated content from separate turns is still delivered.
|
|
if (
|
|
not msg.metadata.get("_stream_delta")
|
|
and not msg.metadata.get("_stream_end")
|
|
and not msg.metadata.get("_streamed")
|
|
):
|
|
if self._should_suppress_outbound(msg):
|
|
logger.info("Suppressing duplicate outbound message to {}:{}", msg.channel, msg.chat_id)
|
|
continue
|
|
await self._send_with_retry(channel, msg)
|
|
else:
|
|
logger.warning("Unknown channel: {}", msg.channel)
|
|
|
|
except asyncio.TimeoutError:
|
|
continue
|
|
except asyncio.CancelledError:
|
|
break
|
|
|
|
@staticmethod
|
|
async def _send_once(channel: BaseChannel, msg: OutboundMessage) -> None:
|
|
"""Send one outbound message without retry policy."""
|
|
if msg.metadata.get("_reasoning_end"):
|
|
await channel.send_reasoning_end(msg.chat_id, msg.metadata)
|
|
elif msg.metadata.get("_reasoning_delta"):
|
|
await channel.send_reasoning_delta(msg.chat_id, msg.content, msg.metadata)
|
|
elif msg.metadata.get("_reasoning"):
|
|
# Back-compat: one-shot reasoning. BaseChannel translates this
|
|
# to a single delta + end pair so plugins only implement the
|
|
# streaming primitives.
|
|
await channel.send_reasoning(msg)
|
|
elif msg.metadata.get("_stream_delta") or msg.metadata.get("_stream_end"):
|
|
await channel.send_delta(msg.chat_id, msg.content, msg.metadata)
|
|
elif not msg.metadata.get("_streamed"):
|
|
await channel.send(msg)
|
|
|
|
def _coalesce_stream_deltas(
|
|
self, first_msg: OutboundMessage
|
|
) -> tuple[OutboundMessage, list[OutboundMessage]]:
|
|
"""Merge consecutive _stream_delta messages for the same (channel, chat_id).
|
|
|
|
This reduces the number of API calls when the queue has accumulated multiple
|
|
deltas, which happens when LLM generates faster than the channel can process.
|
|
|
|
Returns:
|
|
tuple of (merged_message, list_of_non_matching_messages)
|
|
"""
|
|
target_key = (first_msg.channel, first_msg.chat_id)
|
|
combined_content = first_msg.content
|
|
final_metadata = dict(first_msg.metadata or {})
|
|
non_matching: list[OutboundMessage] = []
|
|
|
|
# Only merge consecutive deltas. As soon as we hit any other message,
|
|
# stop and hand that boundary back to the dispatcher via `pending`.
|
|
while True:
|
|
try:
|
|
next_msg = self.bus.outbound.get_nowait()
|
|
except asyncio.QueueEmpty:
|
|
break
|
|
|
|
# Check if this message belongs to the same stream
|
|
same_target = (next_msg.channel, next_msg.chat_id) == target_key
|
|
is_delta = next_msg.metadata and next_msg.metadata.get("_stream_delta")
|
|
is_end = next_msg.metadata and next_msg.metadata.get("_stream_end")
|
|
|
|
if same_target and is_delta and not final_metadata.get("_stream_end"):
|
|
# Accumulate content
|
|
combined_content += next_msg.content
|
|
# If we see _stream_end, remember it and stop coalescing this stream
|
|
if is_end:
|
|
final_metadata["_stream_end"] = True
|
|
# Stream ended - stop coalescing this stream
|
|
break
|
|
else:
|
|
# First non-matching message defines the coalescing boundary.
|
|
non_matching.append(next_msg)
|
|
break
|
|
|
|
merged = OutboundMessage(
|
|
channel=first_msg.channel,
|
|
chat_id=first_msg.chat_id,
|
|
content=combined_content,
|
|
metadata=final_metadata,
|
|
)
|
|
return merged, non_matching
|
|
|
|
async def _send_with_retry(self, channel: BaseChannel, msg: OutboundMessage) -> None:
|
|
"""Send a message with retry on failure using exponential backoff.
|
|
|
|
Note: CancelledError is re-raised to allow graceful shutdown.
|
|
"""
|
|
max_attempts = max(self.config.channels.send_max_retries, 1)
|
|
|
|
for attempt in range(max_attempts):
|
|
try:
|
|
await self._send_once(channel, msg)
|
|
return # Send succeeded
|
|
except asyncio.CancelledError:
|
|
raise # Propagate cancellation for graceful shutdown
|
|
except Exception as e:
|
|
if attempt == max_attempts - 1:
|
|
logger.exception(
|
|
"Failed to send to {} after {} attempts",
|
|
msg.channel, max_attempts
|
|
)
|
|
return
|
|
delay = _SEND_RETRY_DELAYS[min(attempt, len(_SEND_RETRY_DELAYS) - 1)]
|
|
logger.warning(
|
|
"Send to {} failed (attempt {}/{}): {}, retrying in {}s",
|
|
msg.channel, attempt + 1, max_attempts, type(e).__name__, delay
|
|
)
|
|
try:
|
|
await asyncio.sleep(delay)
|
|
except asyncio.CancelledError:
|
|
raise # Propagate cancellation during sleep
|
|
|
|
def get_channel(self, name: str) -> BaseChannel | None:
|
|
"""Get a channel by name."""
|
|
return self.channels.get(name)
|
|
|
|
def get_status(self) -> dict[str, Any]:
|
|
"""Get status of all channels."""
|
|
return {
|
|
name: {
|
|
"enabled": True,
|
|
"running": channel.is_running
|
|
}
|
|
for name, channel in self.channels.items()
|
|
}
|
|
|
|
@property
|
|
def enabled_channels(self) -> list[str]:
|
|
"""Get list of enabled channel names."""
|
|
return list(self.channels.keys())
|